Can IRQ_RX_DONE be set in case of IRQ_HEADER_ERROR?

hugo.lebreton · October 17, 2023, 1:27pm

The driver does not check for IRQ_HEADER_ERROR in case of IRQ_RX_DONE.

Lora-net/LoRaMac-node/blob/master/src/radio/sx126x/radio.c#L1282


{
    TimerStop( &TxTimeoutTimer );
    //!< Update operating mode state to a value lower than \ref MODE_STDBY_XOSC
    SX126xSetOperatingMode( MODE_STDBY_RC );
    if( ( RadioEvents != NULL ) && ( RadioEvents->TxDone != NULL ) )
    {
        RadioEvents->TxDone( );
    }
}

if( ( irqRegs & IRQ_RX_DONE ) == IRQ_RX_DONE )
{
    TimerStop( &RxTimeoutTimer );

    if( ( irqRegs & IRQ_CRC_ERROR ) == IRQ_CRC_ERROR )
    {
        if( RxContinuous == false )
        {
            //!< Update operating mode state to a value lower than \ref MODE_STDBY_XOSC
            SX126xSetOperatingMode( MODE_STDBY_RC );
        }

Most of the time IRQ_RX_DONE is not set in case of IRQ_HEADER_ERROR.
However, in some bad reception events, I noticed that both flags were set simultaneously. Is that possible, or did I miss something?